Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CDML/XML support in open_mfdataset() #503

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Deprecate CDML/XML support in open_mfdataset() #503

merged 2 commits into from
Jun 9, 2023

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jun 9, 2023 •
edited
Loading

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder added the type: docs Updates to documentation label Jun 9, 2023
@tomvothecoder tomvothecoder self-assigned this Jun 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2643f7d) 100.00% compared to head (5256a3d) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #503   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1424      1431    +7     
=========================================
+ Hits          1424      1431    +7
Impacted Files Coverage Δ
xcdat/dataset.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomvothecoder tomvothecoder merged commit 8f32882 into main Jun 9, 2023
@tomvothecoder tomvothecoder deleted the doc/502-add-cdml-deprecation-warning branch June 9, 2023 21:53
@tomvothecoder tomvothecoder mentioned this pull request Jun 9, 2023
Merged
9 tasks
@tomvothecoder tomvothecoder mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomvothecoder tomvothecoder

Labels
type: docs Updates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc]: Add deprecation warning when opening CDML/XML files
2 participants
@tomvothecoder @codecov-commenter